Fix query logic in zopen-install #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonianTeuchter
requested review from
IgorTodorovskiIBM,
MikeFultonDev and
HarithaIBM
as code owners
bin/zopen-install
Outdated
| if [ ${zqrc} -ne 0 ]; then | ||
| printError "Query for installed packages unexpectedly failed; zopen-query returned message: '${chosenRepos}'" | ||
| fi | ||
| elif ${all}; then |
There was a problem hiding this comment.
This logic was moved to https://github.com/ZOSOpenTools/meta/blob/77306255ad11ded06593cbda0d88a47e224e39e3/bin/zopen-install#L637. Do we still need it here?
There was a problem hiding this comment.
No - that was reinstated incorrectly
DevonianTeuchter
deleted the
578-rename-of-query-option-no-versions-breaks-zopen-upgrade
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the zopen-query call to use the updatd parameter no-version rather than no-versions and add more robust error handling if the call was to fail again in future.
Additional test added in metaport PR zopencommunity/metaport#29