Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to zope.interface = 7.2. #1241

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Update to zope.interface = 7.2. #1241

merged 2 commits into from
Dec 3, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 3, 2024

No description provided.

@icemac
Copy link
Member Author

icemac commented Dec 3, 2024

Hm, the broken MacOS runs: That's the problem I want to solve for Products.ZCatalog – I'd not have expected to see it here again.

@d-maurer
Copy link
Contributor

d-maurer commented Dec 3, 2024 via email

@icemac
Copy link
Member Author

icemac commented Dec 3, 2024

@d-maurer wrote:

Maybe, a (pip-) cache issue?

Nope, deleted all caches but got same result.

@dataflake
Copy link
Member

The difference between the broken run and the last good run is that this step:

py39-universal2: install_deps> python -I -m pip install AccessControl Acquisition 'cffi>=1.17.0rc1' charset_normalizer MarkupSafe Persistence 'setuptools<74' 'wheel>0.37' 'zc.buildout>=3.1' zodbpickle zope.container zope.interface zope.security zope.testrunner -c /Users/runner/work/Zope/Zope/constraints.txt

installs zope.interface version 7.1.1 both times. During the last good run that matches what buildout wants to pull later and it's not pulled by buildout. During the bad run buildout doesn't like the already-installed version and wants to get it again, and that breaks.

Honestly, I am just sick and tired of these constant issues, I don't want to deal with it anymore. The tests run fine locally. I don't see how the test failures have any bearing on real life use of Zope. I have literally spent days digging into this and pointing out issues in buildout itself when faced with a universal2 environment and setuptools. None of it got any attention.

@dataflake
Copy link
Member

I just noticed you forgot to update the requirements and constraints files. This may fix it.

@icemac icemac merged commit 7802542 into master Dec 3, 2024
28 checks passed
@icemac icemac deleted the zope.interface-7.2 branch December 3, 2024 07:57
@icemac
Copy link
Member Author

icemac commented Dec 3, 2024

I just noticed you forgot to update the requirements and constraints files. This may fix it.

Sorry, I got so used to the automated way these files are updated in zopetoolkit and all the other places where I use automatic version updates, that I forgot to do it here manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants