Fix authentication error viewing ZMI resource with virtual hosting #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
requested changes
Apr 12, 2024
The previous approach from #1196 was not correct when using virtual host, because AUTHENTICATION_PATH is not usable in virtual host contexts. This uses a different approach, by making the js and css path subscribers take care of generating the URLs with the authentication path prepended using request API aware of virtual hosting.
/++resource++zmi/logo/ and /++resource++logo/ is the same folder on disk, the former is protected by Manage portal and the later is public. Protected resources were problematic, because we want to serve them from the root, but the manager user might not have permission on the root.
Using this approach we serve a resource relative to the path where user is authenticated.
perrinjerome
force-pushed
the
perrinjerome/fix-zmi-user-path
branch
from
fd73b7d to
1a4b3e4
Compare
dataflake
previously approved these changes
Apr 19, 2024
mauritsvanrees
previously approved these changes
Apr 19, 2024
This was referencing an old URL. Co-authored-by: Maurits van Rees <[email protected]>
perrinjerome
dismissed stale reviews from mauritsvanrees and dataflake
via
d8a7054
|
after applying the suggestion of fixing bootstrap url in copyright page, your approvals became "stale", so I had to ask review again. |
mauritsvanrees
approved these changes
Apr 24, 2024
|
Thanks you ! |
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1203