Add preliminary support for Python 3.12rc1.

[icemac]

Let's try out the latest release.

Locally it crashes with with a core-dump when running the tests before printing something useful.

[icemac]

My local failure looks like the GHA one: https://github.com/zopefoundation/Zope/actions/runs/5156707238/jobs/9288068396

[dataflake]

Locally, also on Python 3.12b0, I am seeing this:

$ bin/tox -epy312
py312: install_deps> python -I -m pip install cffi 'wheel>0.37' 'zc.buildout>=3.0.1'
ERROR: Exception:
Traceback (most recent call last):
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/cli/base_command.py", line 160, in exc_logging_wrapper
    status = run_func(*args)
             ^^^^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/cli/req_command.py", line 247, in wrapper
    return func(self, options, args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/commands/install.py", line 326, in run
    session = self.get_default_session(options)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/cli/req_command.py", line 98, in get_default_session
    self._session = self.enter_context(self._build_session(options))
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/cli/req_command.py", line 125, in _build_session
    session = PipSession(
              ^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/network/session.py", line 343, in __init__
    self.headers["User-Agent"] = user_agent()
                                 ^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/network/session.py", line 175, in user_agent
    setuptools_dist = get_default_environment().get_distribution("setuptools")
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/metadata/importlib/_envs.py", line 188, in get_distribution
    return next(matches, None)
           ^^^^^^^^^^^^^^^^^^^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/metadata/importlib/_envs.py", line 183, in <genexpr>
    matches = (
              ^
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/metadata/base.py", line 612, in iter_all_distributions
    for dist in self._iter_distributions():
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/metadata/importlib/_envs.py", line 176, in _iter_distributions
    for dist in finder.find_eggs(location):
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/metadata/importlib/_envs.py", line 144, in find_eggs
    yield from self._find_eggs_in_dir(location)
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_internal/metadata/importlib/_envs.py", line 111, in _find_eggs_in_dir
    from pip._vendor.pkg_resources import find_distributions
  File "/Users/jens/src/zope/Zope/.tox/py312/lib/python3.12/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2164, in <module>
    register_finder(pkgutil.ImpImporter, find_on_path)
                    ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

[icemac]

Let's see what 3.12b2 has to offer.

[icemac]

The result for ubuntu in GHA is:

Tests with errors:
   test_DT_Try__Try__02 (DocumentTemplate.tests.test_DT_Try.DT_Try_Tests.test_DT_Try__Try__02)
   test_DT_Try__Try__06 (DocumentTemplate.tests.test_DT_Try.DT_Try_Tests.test_DT_Try__Try__06)
   test_DT_Try__Try__07 (DocumentTemplate.tests.test_DT_Try.DT_Try_Tests.test_DT_Try__Try__07)
   test_menu_dtml__2 (App.tests.test_ApplicationManager.MenuDtmlTests.test_menu_dtml__2)
   test_Image__manage_main__3 (OFS.tests.testFileAndImage.FileEditTests.test_Image__manage_main__3)
Total: 3245 tests, 0 failures, 5 errors, 37 skipped in 23.223 seconds.

That's way better but also a bit surprising, that DTML tests fail.

[icemac]

Locally I seem to get the same 5 errors + lots of deprecation warnings. So clearly a step forward.

[dataflake]

My "broken" Python 3.12 is the result of virtualenv (via tox) installing pip version 22.3.1 into the Python 3.12 virtual environment. Pip 22.3.1 is not compatible with Python 3.12. The solution is to use environment variables inside tox.ini testenv to force a newer pip:

[testenv]
+setenv =
+    py312: VIRTUALENV_PIP=23.1.2
+    py312: PIP_REQUIRE_VIRTUALENV=0

Question: I can simply add this in .meta.toml here, or I can add it to the template file in the meta repository itself. I am sure others will run into the same issue.

[icemac]

@dataflake Do you have a clue why tox uses an outdated pip version? Do you use a current tox version and is there a current pip installed in the venv where tox is installed?

I'd like to find out why this problem does not happen to me and I'd like to get around stuffing a hard coded version number into a config file.

If we do not find out the cause of the problem I think your changes should got into meta/config so they can be changed in one place instead of having it in several .meta.toml files.

[dataflake]

What will happen is that regardless of the pip version at the top/repository level the virtual environment created by tox at .tox/py312 has the old version of pip installed.

This is not a tox issue but virtualenv. There's this whole nasty chain of one package vendoring other packages or prescribing a specific version. I found the workaround here: qutebrowser/qutebrowser@0b0401f

[icemac]

@dataflake Okay, let's move this fix into meta/config until there is new enough version of virtualenv released.

[dataflake]

The test failures under Python 3.12 are actually a zope.testrunner issue: zopefoundation/zope.testrunner#149

[dataflake]

I just confirmed that these errors are fixed with zopefoundation/zope.testrunner#150 applied.

[dataflake]

This PR will go green when zope.testrunner 6.1 is on PyPI and pinned here, I'm just waiting for the required privileges.

[dataflake]

The last remaining failure looks like a tox issue to me

[icemac]

47d82b2 has to be ported to .meta.toml so it is not lost on the next meta/config run.

[dataflake]

47d82b2 has to be ported to .meta.toml so it is not lost on the next meta/config run.

Done.

[dataflake]

I have removed the tags, IMHO this is ready to be merged.

[icemac]

Thank you for working on this PR. 😃
After it has been merged I'd like to cut a new Zope 5 release.

[dataflake]

Fine by me. Do you want me to do it? I have time this morning.

[icemac]

Fine by me. Do you want me to do it? I have time this morning.

This would be very helpful as I'd would try to do it tomorrow. (Could you in the announcement please also mention the Zope 4.8.9 release fixing the same security issues?)

[dataflake]

Yes, will do.

[icemac]

@dataflake Thank you very much!