Run isort, autopep8 and flake8 in pre-commit.

.github/workflows/pre-commit.yml

@@ -0,0 +1,23 @@
+name: pre-commit
+
+on:
+  pull_request:
+  push:
+    branches:
+    - master
+jobs:
+  pre-commit:
+    name: pre-commit linting
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: actions/setup-python@v5
+      with:
+        python-version: 3.x
+    - uses: pre-commit/[email protected]
+      with:
+        extra_args: --all-files
+    - uses: pre-commit-ci/[email protected]
+      if: always()
+      with:
+        msg: Apply pre-commit code formatting

.pre-commit-config.yaml

@@ -1,6 +1,23 @@
+minimum_pre_commit_version: '3.6'
 repos:
+  - repo: https://github.com/pycqa/isort
+    rev: "5.13.2"
+    hooks:
+    - id: isort
+  - repo: https://github.com/hhatto/autopep8
+    rev: "v2.3.1"
+    hooks:
+    - id: autopep8
+      args: [--in-place, --aggressive, --aggressive]
   - repo: https://github.com/asottile/pyupgrade
-    rev: v2.6.2
+    rev: v3.17.0
     hooks:
     - id: pyupgrade
-      args: [--py36-plus]
+      args: [--py38-plus]
+  - repo: https://github.com/PyCQA/flake8
+    rev: "6.1.0"
+    hooks:
+    - id: flake8
+      additional_dependencies:
+        - flake8-coding == 1.3.2
+        - flake8-debugger == 4.1.2

docs/conf.py

@@ -100,7 +100,7 @@
     "light_logo": "Zope.svg",
     "dark_logo": "Zope.svg",
     "light_css_variables": {
-#        "color-brand-content": "#00AAD4",  # Too light for white background
+        # "color-brand-content": "#00AAD4",  # Too light for white background
     },
     "dark_css_variables": {
         "color-brand-content": "#00AAD4",

src/ZPublisher/BaseRequest.py

@@ -710,11 +710,10 @@ def ensure_publishable(self, obj, for_call=False):
             # a tuple of allowed request methods
             request_method = (getattr(self, "environ", None)
                               and self.environ.get("REQUEST_METHOD"))
-            if  (request_method is None  # noqa: E271
-                 or request_method.upper() not in publishable):
-                raise Forbidden(
-                    f"The object at {url} does not support "
-                    f"{request_method} requests")
+            if (request_method is None  # noqa: E271
+                    or request_method.upper() not in publishable):
+                raise Forbidden(f"The object at {url} does not support "
+                                f"{request_method} requests")
             return
         # ``publishable`` is ``None``