Rails 5.2 specs - Remove calling run_callbacks commit spec workarounds #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork without calling callback in Rails 5+
Tooyosi
approved these changes
Oct 23, 2024
yuenmichelle1
deleted the
rails-5.2-spec-fixes-ensure-creation-for-after_commit-callback-specs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://stackoverflow.com/a/30901628/15768801
In Rails versions < 5, in order to test after_commit callbacks, one would have to actually run the commit callback via
run_callbacks. This issue gets fixed in Rails 5+.