Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 5 - Update searches_controller search_href to use permitted params and then convert to hash because params no longer inherits from HashWithIndifferentAccess #356

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Rails 5 - Update searches_controller search_href to use permitted params and then convert to hash because params no longer inherits from HashWithIndifferentAccess #356

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
665d80f
update searches_controller to use permitted params and then call to_h…
yuenmichelle1 Aug 8, 2024
3069cc9
Merge branch 'master' into rails-5---deprecated-method-collect-in-sea…
yuenmichelle1 Aug 8, 2024
6d8f30d
Merge branch 'master' into rails-5---deprecated-method-collect-in-sea…
yuenmichelle1 Aug 9, 2024
6ad570b
Merge branch 'master' into rails-5---deprecated-method-collect-in-sea…
yuenmichelle1 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/searches_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def previous_href
end

def search_href(opts = { })
permitted = params.slice :page, :page_size, :section, :query, :types
permitted = permit_params.to_h.slice :page, :page_size, :section, :query, :types
query_opts = permitted.merge(opts).collect{ |k, v| "#{ k }=#{ v }" }.join '&'
"/searches?#{ query_opts }"
end
Expand Down
Loading