Rails 5.0 -- Fix comments_controller_spec.rb and moderations_controller_spec.rb #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom HashWithIndifferentAccess
…to permit params in order for added attributes to be included when converting to a hash with to_h
yuenmichelle1
changed the title
Tooyosi
approved these changes
Jul 1, 2024
This was referenced Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
permitparams and convertto_hbecause AC Params no longer inherits fromHashWithIndifferentAccesshttps://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#actioncontroller-parameters-no-longer-inherits-from-hashwithindifferentaccess.- Our fork/talk-version of restpack-serializer expects params to come in as a
Hash(otherwise will return filters as{}when we do have filters in our params) See: https://github.com/zooniverse/restpack_serializer/blob/637aaaf85eda4f467c034f19f52e3f0cb6b20112/lib/restpack_serializer/options.rb#L58This reminds me that as a future TODO: We need to update our fork talk-api branch of restpack-serializer, similar to how we did panoptes. (I.e. update
protected_attributesgem withprotected_attributes_continuedand update version constraints)