Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails dual boot #318

Merged
merged 6 commits into from
May 23, 2024
Merged

Rails dual boot #318

merged 6 commits into from
May 23, 2024

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented May 21, 2024 •
edited
Loading

Start of Upgrading Talk to Rails.

First dual boot bump is to Ruby 2.6 and Rails 5.0.7.2

zwolf
zwolf approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds successfully for me, though I am getting the celluloid error you mentioned in slack when I try to run the tests. Assuming that's solved by removing in the sidetiq PR, LGTM.

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review May 23, 2024 05:19
@yuenmichelle1 yuenmichelle1 merged commit e72d51a into master May 23, 2024
1 of 2 checks passed
@yuenmichelle1 yuenmichelle1 mentioned this pull request May 28, 2024
Merged
@yuenmichelle1 yuenmichelle1 deleted the rails-dual-boot branch June 18, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwolf zwolf zwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuenmichelle1 @zwolf