Skip to content

Commit

Permalink
rails 5.1 dockerfile-next on staging (#369)
Browse files Browse the repository at this point in the history
update deploye_staging to use dockerfile-next commits
update canary replicas to 0.
add TODO comment on gemfile as reminder of when to update a rspec-rails gem

TODO need to run deploy staging canary GH action in order to get this change to apply to staging canary
  • Loading branch information
yuenmichelle1 authored Sep 3, 2024
1 parent bab1356 commit bf6c6e1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/deploy_staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ jobs:
uses: zooniverse/ci-cd/.github/workflows/build_and_push_image.yaml@main
with:
repo_name: talk-api
commit_id: ${{ github.sha }}
commit_id: ${{ github.sha }}-next
file: Dockerfile.rails-next
latest: true

db_migration_staging:
Expand All @@ -22,7 +23,7 @@ jobs:
with:
app_name: talk-api
environment: staging
commit_id: ${{ github.sha }}
commit_id: ${{ github.sha }}-next
secrets:
creds: ${{ secrets.AZURE_AKS }}

Expand All @@ -33,7 +34,7 @@ jobs:
with:
app_name: talk-api
repo_name: talk-api
commit_id: ${{ github.sha }}
commit_id: ${{ github.sha }}-next
environment: staging
secrets:
creds: ${{ secrets.AZURE_AKS }}
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ group :test, :development do
gem 'guard-rspec'
gem 'pry'
gem 'rspec-its'
gem 'rspec-rails', '~> 4.1.2'
gem 'rspec-rails', '~> 4.1.2' # upgrade when on rails 5.2
gem 'spring-commands-rspec'
gem 'ten_years_rails'
gem 'timecop'
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/deployment-staging-canary.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
labels:
app: talk-staging-canary-app
spec:
replicas: 1
replicas: 0
selector:
matchLabels:
app: talk-staging-canary-app
Expand Down

0 comments on commit bf6c6e1

Please sign in to comment.