Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated design system links #5149

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Updated design system links #5149

merged 2 commits into from
Aug 10, 2023

Conversation

seanmiller26
Copy link
Contributor

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

Linked Issue and/or Talk Post

Describe your changes

How to Review

Helpful explanations that will make your reviewer happy:

  • What Zooniverse project should my reviewer use to review UX?
  • What user actions should my reviewer step through to review this PR?
  • Which storybook stories should be reviewed?
  • Are there plans for follow up PR’s to further fix this bug or develop this feature?

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

Maintenance

  • If not from dependabot, the PR creator has described the update (major, minor, or patch version, changelog)

Post-merge

  • This PR adds translations keys to English dictionary(s). See guidance for pulling new keys to Lokalise here.

@coveralls
Copy link

coveralls commented Aug 10, 2023

Coverage Status

coverage: 82.01% (-0.006%) from 82.016% when pulling c104e39 on seanmiller26-patch-1 into b321445 on master.

@github-actions github-actions bot added the approved This PR is approved for merging label Aug 10, 2023
@goplayoutside3 goplayoutside3 merged commit 0124b0d into master Aug 10, 2023
8 checks passed
@goplayoutside3 goplayoutside3 deleted the seanmiller26-patch-1 branch August 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants