"Classify this Subject" feature: use live active Workflow data #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Our recent experience with the Stereovision project has highlighted the following issues:
This PR attempts to address the issues above by pulling live active Workflow data for a given Project, and ensuring a Subject "belongs" to at least one active
active_workflow.links.subject_sets
andsubject.links.subject_sets
; if there's at least one matching subject set, then a volunteer can classify that Subject on that Workflow.Also:
Screenshot: WorkflowSelectionDialog after clicking "Classify this Subject" on a Stereovision Subject
Screenshot: similar to above, but the Subject is a test subject that's not associated with any active workflows
Future ideas: since we know the completeness of each live workflow, we can also grey out workflows that are complete. The screenshot below demonstrates how this might look like, and the feature is already partially implemented in the code. (We're just missing good design, and actually completed workflows to test it.)
NOTE: these changes, when deployed, will only affect the Stereovision project. We could easly apply these changes to How Did We Get Here by changing the project config if we wanted, but I'll try my best to not disturb older projects.
Status
Ready to go, but do NOT merge and deploy until we get the green light. We don't want to deploy major feature changes while the Stereovision team is still getting a feel for the Community Catalog