Fixed minor bug parsing url connection. Updated dependencies libraries. #209
Conversation
|
Thank you. It seems by updating the credo package a new rule was introduced and the credo task returns a ' Refactoring opportunities'. Please change the value to 4 or disable the rule to continue the workflow. |
|
Hi. I have updated the credo config file to allow max_nesting value to 4. Now it must return the same output than previous version. Looks like the function ReadPreference.primary() has been deleted in master branch. I think now we must use the function ReadPreference.merge_default(), so I have updated the test topology_test.exs file to use this new function. Regards. |
|
Hello. Why is failing the release-please action?? Reviewing the logs I see this message:
Is there something that I must do to fix this? Regards. |
* fix: handle read preferences without tags * Fixed minor bug parsing url connection. Updated dependencies libraries. (#209) * Fixed minor bug parsing url connection. Updated dependencies libraries. * Incremented max_nesting option in credo refactor nestring * Changed function ReadPreference.primary() by ReadPreference.merge_defaults() in topology test file --------- Co-authored-by: Juan Antonio Jiménez <[email protected]> Co-authored-by: Michael Maier <[email protected]> * fix: applies the global timeout value to each query (#215) * Document BSON.Decoder and BSON.PreserveOrderDecoder But keep the documentation for those modules private for now. Expand the documentation on Data Representation and how to deal with preserving key order when encoding and decoding data. * Test BSON decoders * Document how to go from annotated maps with order keys to lists --------- Co-authored-by: zookzook <[email protected]> Co-authored-by: Juan Antonio <[email protected]> Co-authored-by: Juan Antonio Jiménez <[email protected]>
Hi!
I have found the url parser didn't work with url like "mongodb://localhost/", so I have made some changes in the regular expression to support this and other cases like options format following the mongodb specs. I have added tests from this spec too.
Besides, I have update some libraries to avoid some warnings while compiling and add a @tag :rs_required to some tests that need a replica set to be executed correctly, like the ones that use transactions.
Regards.