Allow construction of empty Zonemaster::LDNS::RRList objects #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-vanderwal
requested review from
mattias-p,
matsduf,
tgreenx and
MichaelTimbert
marc-vanderwal
changed the title
|
CI failures seem to be addressed in #208. |
tgreenx
previously approved these changes
Oct 16, 2024
The change in zonemaster#203 introduced a new() function in the Zonemaster::LDNS::RRList module. However, calling new() with a ref to an empty array as paramater caused the code to croak with the error message "List is empty". However, there are situations where it may be desirable to construct such an empty RRList. This commit ensures that Zonemaster::LDNS::RRList->new([]) works as intended.
Modify the XS code so that Zonemaster::LDNS::RRList::new() can be called with zero arguments, which is equivalent to passing it an empty arrayref.
marc-vanderwal
force-pushed
the
bugfix/allow-empty-rrlists
branch
from
65024d6 to
a9cac1c
Compare
|
I’ve rebased on latest develop so that CI works, and included another minor change in |
mattias-p
previously approved these changes
Oct 18, 2024
Let’s make sure that new() and new([]) have the same semantics, and that the eq operator works correctly in both ways with these empty lists.
tgreenx
approved these changes
Oct 21, 2024
|
@mattias-p @mattias-p please review so it can be merged and zonemaster/zonemaster-engine#1383 updated before the end of development. |
mattias-p
approved these changes
Nov 6, 2024
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Nov 7, 2024
These objects can now be created from empty lists, see zonemaster/zonemaster-ldns#209
matsduf
added
the
V-Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses a design oversight in the constructor for Zonemaster::LDNS::RRList objects. It was for now assumed that it would always be used to construct nonempty RRList objects, but a PR in Zonemaster-Engine elicited the need for exactly that use case.
Context
Follow-up to #203; review of zonemaster/zonemaster-engine#1383.
Changes
Allow calling Zonemaster::LDNS::RRList::new() with either no argument or an empty arrayref.
How to test this PR
Unit tests were added, and should therefore pass.