Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for v2024.2 release (Engine) #1410

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Dec 6, 2024

Purpose

This PR is a preparation for v2024.2 release.

Changes

  • Changes
  • lib/Zonemaster/Engine.pm
  • Makefile.PL

Note

CI will fail until zonemaster/zonemaster-ldns#214 is merged.

How to test this PR

Review.

@matsduf matsduf added the P-High Priority: Issue to be solved before other label Dec 6, 2024
@matsduf matsduf added this to the v2024.2 milestone Dec 6, 2024
marc-vanderwal
marc-vanderwal previously approved these changes Dec 9, 2024
mattias-p
mattias-p previously approved these changes Dec 9, 2024
Changes Outdated Show resolved Hide resolved
Changes Outdated
- Updates DNSSEC10 implementation (#1396)
- Updates global cache and makes the feature being supported and not
experimental (#1394)
- Update Connectivity04 implementation (#1393)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be moved to the Fixes category. The PR is marked with V-Patch and at least to me it feels more like a patch than a minor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Co-authored-by: Mattias Päivärinta <[email protected]>
@matsduf matsduf dismissed stale reviews from mattias-p and marc-vanderwal via 73a3fb8 December 9, 2024 09:40
@matsduf
Copy link
Contributor Author

matsduf commented Dec 9, 2024

@mattias-p, @marc-vanderwal, please re-approve after editorial changes.

Changes Outdated Show resolved Hide resolved
Changes Outdated Show resolved Hide resolved
Changes Outdated Show resolved Hide resolved
Changes Outdated Show resolved Hide resolved
Changes Outdated Show resolved Hide resolved
@matsduf matsduf requested a review from tgreenx December 9, 2024 10:37
@matsduf
Copy link
Contributor Author

matsduf commented Dec 9, 2024

@mattias-p, @marc-vanderwal and @tgreenx: please (re-)approve after editorial changes.

@matsduf matsduf merged commit 8cb771b into zonemaster:develop Dec 9, 2024
1 of 3 checks passed
@matsduf matsduf deleted the preparation-release-v2024.2 branch December 9, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-High Priority: Issue to be solved before other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants