Add Try::Tiny in zonemaster-cli runtime Docker container #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running “docker build” on Zonemaster-Engine caused a warning to appear on my test system: 1 warning found (use docker --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
Try::Tiny was missing from the run-time container.
marc-vanderwal
added
T-Bug
marc-vanderwal
requested review from
mattias-p,
matsduf,
tgreenx and
MichaelTimbert
matsduf
approved these changes
Nov 29, 2024
tgreenx
approved these changes
Dec 2, 2024
tgreenx
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR installs a missing runtime dependency in the Docker container for Zonemaster-CLI.
Context
Release testing for the upcoming 2024.2 release.
Changes
docker builddue to the capitalization of theaskeyword on the first line of the Dockerfile.How to test this PR
Build the Docker container, then perform the “smoke test” for Zonemaster::Engine:
The program should complete, and should not error out because of a missing package.