Remove unused values from default params #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the Fitbit API appears to throw bad request errors if passing empty params to some of its endpoints - in particular it would error out on the activity logs list endpoint as both the beforeDate and afterDate params are being sent over, even though the afterDate param is null by default. Previously, it looks like Fitbit's API would gracefully handle these nil params but in this case it explicitly fails as you can't have both a before and after date set at the same time. This updates affected methods so that unused values are removed from the default params object. There should be no difference in behavior other than fixing the recently broken activity logs endpoint. Addresses #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the Fitbit API appears to throw bad request errors if passing empty params to some of its endpoints - in particular it would error out on the activity logs list endpoint as both the beforeDate and afterDate params are being sent over, even though the afterDate param is null by default. Previously, it looks like Fitbit's API would gracefully handle these nil params but in this case it explicitly fails as you can't have both a before and after date set at the same time.
This updates affected methods so that unused values are removed from the default params objects. There should be no difference in behavior other than fixing the recently broken activity logs endpoint.
Addresses #12