Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable InputFields::ModernizedSelection::MaxNumberOfOptions. #576

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

itweserems
Copy link
Contributor

Proposed change

See #575:
When using dynamic fields of type "dropdown" or "multiselect", the default code-setup is that the layout of a select-field (e.g. dynamic field) will be changed when the amount of selectable values is above 1000.

This is for performance reasons, but the limit should be configurable. The layout for fields with >1000 values does not allow searching values and with a configurable maximum number can be set to an individual level to keep the search functionality as long as performance goes along with this.

Type of change

1 - 🚀 feature

Breaking change

Additional information

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 1 - 🚀 feature New feature or request 4 - verified This issue or pull request was verified. labels Jun 27, 2024
@rkaldung
Copy link
Member

@jepf Please check the new system configuration name, the feature looks fine.

Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itweserems ,
thanks for your PR.

I have a few change requests here.

Regards 🚀

Kernel/Output/HTML/Layout.pm Outdated Show resolved Hide resolved
Kernel/Language/de.pm Outdated Show resolved Hide resolved
Kernel/Config/Files/XML/Framework.xml Outdated Show resolved Hide resolved
var/httpd/htdocs/js/Core.UI.InputFields.js Outdated Show resolved Hide resolved
@dennykorsukewitz
Copy link
Member

dennykorsukewitz commented Oct 30, 2024

Hi @itweserems

thank you for your PullRequest.
We will merge this PR and move this setting after following setting.

    <Setting Name="ModernizeCustomerFormFields" Required="1" Valid="1">
        <Description Translatable="1">Use new type of select and autocomplete fields in customer interface, where applicable (InputFields).</Description>
        <Navigation>Frontend::Customer</Navigation>
        <Value>
            <Item ValueType="Checkbox">1</Item>
        </Value>
    </Setting>

Good Job. 🚀

@dennykorsukewitz dennykorsukewitz added the 3 - wait for contributor Contributor, it's your turn. label Oct 30, 2024
@dennykorsukewitz dennykorsukewitz changed the title Configurable MaxNumberOfOptions #575 Configurable InputFields::ModernizedSelection::MaxNumberOfOptions #575 Oct 30, 2024
@dennykorsukewitz dennykorsukewitz changed the title Configurable InputFields::ModernizedSelection::MaxNumberOfOptions #575 Configurable InputFields::ModernizedSelection::MaxNumberOfOptions Oct 30, 2024
@dennykorsukewitz dennykorsukewitz added 3 - wait for merge Znuny, it's your turn. and removed 3 - wait for contributor Contributor, it's your turn. labels Oct 31, 2024
@dennykorsukewitz dennykorsukewitz added this to the rel-7_1_4 milestone Oct 31, 2024
@dennykorsukewitz dennykorsukewitz self-assigned this Oct 31, 2024
@dennykorsukewitz dennykorsukewitz changed the title Configurable InputFields::ModernizedSelection::MaxNumberOfOptions Added configurable InputFields::ModernizedSelection::MaxNumberOfOptions. Nov 1, 2024
@dennykorsukewitz dennykorsukewitz merged commit cd5b268 into znuny:dev Nov 1, 2024
13 of 14 checks passed
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for merge Znuny, it's your turn. label Nov 1, 2024
@dennykorsukewitz dennykorsukewitz removed the request for review from jepf November 1, 2024 11:52
@itweserems
Copy link
Contributor Author

itweserems commented Dec 13, 2024

Hi @dennykorsukewitz,
sorry for not responding on this but thanks for making the changes and merging this!

BR, Paul 🚀

@dennykorsukewitz
Copy link
Member

Hi @dennykorsukewitz, sorry for not responding on this but thanks for making the changes and merging this!

BR, Paul 🚀

Hi @itweserems

I usually have more patience and wait, but I didn't want to leave this finished PullRequest lying around unnecessarily.
Thanks for your contribution.

👍🏼 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🚀 feature New feature or request 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

4 participants