Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect comparison in ACL module skipping logic #472

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fixed incorrect comparison in ACL module skipping logic #472

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e205dd5
Fixed ReturnSubType check
tipue-dev Aug 1, 2023
c4a30ad
Fixed wrong reference
tipue-dev Sep 1, 2023
6cf76a3
Merge branch 'dev' into dev-ACL_Module_fix
dennykorsukewitz Nov 23, 2023
038d154
Merge branch 'dev' into dev-ACL_Module_fix
dennykorsukewitz Feb 6, 2024
c829298
Merge branch 'dev' into dev-ACL_Module_fix
dennykorsukewitz Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Kernel/System/Ticket/TicketACL.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,14 @@ sub TicketAcl {
next MODULENAME;
}
if ( $Module->{ReturnSubType} ) {
if ( ref( $Module->{ReturnSubType} ) eq 'HASH' ) {
if ( ref( $Module->{ReturnSubType} ) eq 'ARRAY' ) {
next MODULENAME if !grep { $Param{ReturnSubType} eq $_ }
@{ $Module->{ReturnSubType} };
}
else {

# a scalar, we hope
next MODULENAME if !$Module->{ReturnSubType} eq $Param{ReturnSubType};
next MODULENAME if $Module->{ReturnSubType} ne $Param{ReturnSubType};
}
}

Expand Down
Loading