fixed duplicate execution of meta-cmds

zms-publishing · Sep 25, 2023 · 33652e4 · 33652e4
1 parent b6cfc37
commit 33652e4
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/Products/zms/zmsobject.py b/Products/zms/zmsobject.py
@@ -1241,8 +1241,8 @@ def manage_executeMetacmd(self, lang, REQUEST, RESPONSE=None):
       if metaCmd is not None:
         # Execute directly.
         ob = zopeutil.getObject(self, id)
-        value = zopeutil.callObject(ob, zmscontext=self)
         if not metaCmd['id'].startswith('manage_tab_') and metaCmd.get('execution', 0) == 1:
+          value = zopeutil.callObject(ob, zmscontext=self)
           if isinstance(value, str):
             message = value
           elif isinstance(value, tuple):
@@ -1256,8 +1256,7 @@ def manage_executeMetacmd(self, lang, REQUEST, RESPONSE=None):
             status = 201 # Turbolinks
             RESPONSE.setHeader('Location',loc)
             RESPONSE.setHeader('Turbolinks-Location',loc)
-          RESPONSE.redirect(loc,status=status)
-          return value
+          return RESPONSE.redirect(loc,status=status)
 
       # Return with message.
       message = standard.url_quote(message)