style: reformat all go files #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developStorm
force-pushed
the
build/go-formatter
branch
3 times, most recently
from
d1cc022 to
70122bd
Compare
developStorm
force-pushed
the
build/go-formatter
branch
8 times, most recently
from
2c7d103 to
cee0b27
Compare
developStorm
force-pushed
the
build/go-formatter
branch
from
cee0b27 to
8eb7a46
Compare
phillip-stephens
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Overall looks good, thanks for taking this up @developStorm !
One thing, could we add a make lint similar to here so it's easier to do this locally without hunting for the gofmt command?
|
Thanks for reviewing @phillip-stephens! Implemented in 18d5069. I did only go fmt since linter is out of scope of this PR... |
phillip-stephens
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And activate go formatter workflow