netkvm: fix memory leak in TX overfragmenting flow

https://issues.redhat.com/browse/RHEL-24992 Memory leak of CNB::m_ExtraNBStorage happens if the packet os overfragmented but we do not succeed to allocate extra pages. Signed-off-by: Yuri Benditovich <[email protected]>
zjmletang · Apr 11, 2024 · 8b6f5ef · 8b6f5ef
1 parent 6eca3b8
commit 8b6f5ef
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/NetKVM/Common/ParaNdis_TX.cpp b/NetKVM/Common/ParaNdis_TX.cpp
@@ -809,6 +809,11 @@ CNB::~CNB()
     {
         NdisMFreeNetBufferSGList(m_Context->DmaHandle, m_SGL, m_NB);
     }
+    if (m_ExtraNBStorage)
+    {
+        // for unknown case it was not freed before
+        ReturnPages();
+    }
 }
 
 void CNB::ReleaseResources()
@@ -1221,6 +1226,8 @@ NBMappingStatus CNB::AllocateAndFillCopySGL(ULONG ParsedHeadersLength)
     RtlZeroMemory(m_ExtraNBStorage, sizeof(CExtendedNBStorage));
     if (!m_ParentNBL->GetParentTXPath()->BorrowPages(m_ExtraNBStorage, Pages))
     {
+        NdisFreeMemory(m_ExtraNBStorage, sizeof(CExtendedNBStorage), 0);
+        m_ExtraNBStorage = NULL;
         return NBMappingStatus::NO_RESOURCE;
     }