Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to specify extraContainers #287

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PurseChicken
Copy link
Contributor

@PurseChicken PurseChicken commented Dec 14, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

Description

This PR adds the ability to utlize extraContainers in the containers spec both globally as well as on individual pods \ jobs.

Main Zitadel Deployment --> .Values.extraContainers
Init Job --> .Values.initJob.extraContainers
Setup Job --> .Values.setupJob.extraContainers
debug_replicaset --> .Values.zitadel.debug.extraContainers

If you specify extraContainers via .Values.zitadel.extraContainers then these will apply to all the above pods.

This will be incredibly useful for various reasons including the ability to add sidecar's like CloudSQL Proxy. I included a commented example of this in the values file in the global extraContainers list (.Values.zitadel.extraContainers)

@PurseChicken PurseChicken marked this pull request as ready for review December 14, 2024 23:28
@eliobischof eliobischof self-requested a review December 15, 2024 09:57
@eliobischof eliobischof self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants