Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add IDPs to invite flow #323

Merged
merged 12 commits into from
Dec 27, 2024
Merged

fix: add IDPs to invite flow #323

merged 12 commits into from
Dec 27, 2024

Conversation

peintnermax
Copy link
Member

This PR adds IDPs to the invite flow. On the page where users are able to choose an auth method, idps which allow linking are shown.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected on good and bad user inputs, ZITADEL responses or IDP redirects. The ZITADEL API is mocked, IDP redirects are simulated.
  • Playwright acceptances tests ensure that the happy paths of common user journeys work as expected. The ZITADEL API is not mocked but IDP redirects are simulated.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 11:14am

@peintnermax peintnermax marked this pull request as ready for review December 23, 2024 08:37
@peintnermax peintnermax requested review from eliobischof and removed request for eliobischof December 23, 2024 08:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • apps/login/locales/de.json: Language not supported
  • apps/login/locales/en.json: Language not supported
  • apps/login/locales/es.json: Language not supported
  • apps/login/locales/it.json: Language not supported
  • apps/login/locales/zh.json: Language not supported
  • apps/login/src/components/sign-in-with-idp.tsx: Evaluated as low risk
  • apps/login/src/lib/server/email.ts: Evaluated as low risk
  • apps/login/src/app/(login)/authenticator/set/page.tsx: Evaluated as low risk
  • apps/login/src/lib/server/loginname.ts: Evaluated as low risk
  • apps/login/src/app/(login)/idp/[provider]/success/page.tsx: Evaluated as low risk
  • apps/login/src/lib/zitadel.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

apps/login/src/components/idps/pages/login-failed.tsx:8

  • [nitpick] The default parameter 'error: string = ""' in the loginFailed function might be unnecessary and can be simplified.
error: string = ""

apps/login/src/app/(login)/idp/[provider]/failure/page.tsx:31

  • [nitpick] Ensure that the class name 'ztdl-p' is defined and used consistently across the codebase.
<p className="ztdl-p">{t("loginError.description")}</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • apps/login/locales/de.json: Language not supported
  • apps/login/locales/en.json: Language not supported
  • apps/login/locales/es.json: Language not supported
  • apps/login/locales/it.json: Language not supported
  • apps/login/locales/zh.json: Language not supported
  • apps/login/src/lib/server/email.ts: Evaluated as low risk
  • apps/login/src/lib/server/loginname.ts: Evaluated as low risk
  • apps/login/src/lib/zitadel.ts: Evaluated as low risk
  • apps/login/src/components/sign-in-with-idp.tsx: Evaluated as low risk
  • apps/login/src/app/(login)/authenticator/set/page.tsx: Evaluated as low risk
  • apps/login/src/app/(login)/idp/[provider]/success/page.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

apps/login/src/components/idps/pages/linking-failed.tsx:6

  • [nitpick] The function name 'linking_failed' should be renamed to 'linkingFailed' to follow camelCase naming conventions.
export async function linking_failed(branding?: BrandingSettings) {
@eliobischof eliobischof merged commit 5f19892 into main Dec 27, 2024
8 checks passed
@eliobischof eliobischof deleted the idp-invite branch December 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants