-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add IDPs to invite flow #323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- apps/login/locales/de.json: Language not supported
- apps/login/locales/en.json: Language not supported
- apps/login/locales/es.json: Language not supported
- apps/login/locales/it.json: Language not supported
- apps/login/locales/zh.json: Language not supported
- apps/login/src/components/sign-in-with-idp.tsx: Evaluated as low risk
- apps/login/src/lib/server/email.ts: Evaluated as low risk
- apps/login/src/app/(login)/authenticator/set/page.tsx: Evaluated as low risk
- apps/login/src/lib/server/loginname.ts: Evaluated as low risk
- apps/login/src/app/(login)/idp/[provider]/success/page.tsx: Evaluated as low risk
- apps/login/src/lib/zitadel.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
apps/login/src/components/idps/pages/login-failed.tsx:8
- [nitpick] The default parameter 'error: string = ""' in the loginFailed function might be unnecessary and can be simplified.
error: string = ""
apps/login/src/app/(login)/idp/[provider]/failure/page.tsx:31
- [nitpick] Ensure that the class name 'ztdl-p' is defined and used consistently across the codebase.
<p className="ztdl-p">{t("loginError.description")}</p>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- apps/login/locales/de.json: Language not supported
- apps/login/locales/en.json: Language not supported
- apps/login/locales/es.json: Language not supported
- apps/login/locales/it.json: Language not supported
- apps/login/locales/zh.json: Language not supported
- apps/login/src/lib/server/email.ts: Evaluated as low risk
- apps/login/src/lib/server/loginname.ts: Evaluated as low risk
- apps/login/src/lib/zitadel.ts: Evaluated as low risk
- apps/login/src/components/sign-in-with-idp.tsx: Evaluated as low risk
- apps/login/src/app/(login)/authenticator/set/page.tsx: Evaluated as low risk
- apps/login/src/app/(login)/idp/[provider]/success/page.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)
apps/login/src/components/idps/pages/linking-failed.tsx:6
- [nitpick] The function name 'linking_failed' should be renamed to 'linkingFailed' to follow camelCase naming conventions.
export async function linking_failed(branding?: BrandingSettings) {
Co-authored-by: Elio Bischof <[email protected]>
This PR adds IDPs to the invite flow. On the page where users are able to choose an auth method, idps which allow linking are shown.
Definition of Ready