Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(acceptance): use prod secret on command test:acceptance:prod #311

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore(acceptance): use prod secret on command test:acceptance:prod #311

merged 1 commit into from
Dec 5, 2024

Conversation

eliobischof
Copy link
Member

Acceptance tests with "test:acceptance:prod" run against QA. The reason is that the bash logical operators aren't evaluated as expected.

To fix this, we explicitly test the command in an if condition.

Completes #303
Contributes to #51

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 0:17am

@eliobischof eliobischof self-assigned this Dec 5, 2024
@eliobischof eliobischof requested a review from stebenz December 5, 2024 12:19
@eliobischof eliobischof marked this pull request as ready for review December 5, 2024 12:19
@eliobischof eliobischof merged commit 5b68487 into main Dec 5, 2024
9 checks passed
@eliobischof eliobischof deleted the fix-acceptance-against-prod branch December 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliobischof @stebenz