Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AssociativeFlattenCovariantOps#flatMap code #1417

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

guizmaii
Copy link
Member

No description provided.

@guizmaii guizmaii requested a review from a team as a code owner November 14, 2024 02:52
@guizmaii guizmaii self-assigned this Nov 14, 2024
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we're in the definition of an extension method. Here, isn't it better to use bare instances and there methods (instead of other extension methods)?

But if you feel strongly about it, feel free to merge.

@guizmaii
Copy link
Member Author

guizmaii commented Nov 17, 2024

Hey @sideeffffect,

I don't feel strongly about this change
I tend just to trust the Scala compiler to do the right thing (which I might be wrong about 😅)

@ghostdogpr @kyri-petrou Any opinion about this? 🤔

@guizmaii guizmaii merged commit 641d320 into series/2.x Nov 20, 2024
21 checks passed
@guizmaii guizmaii deleted the simplify_AssociativeFlattenCovariantOps branch November 20, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants