🥗 Tobias: Issuing indivisible Payout#amount rounds each Payment#amount down
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Beneficiary` `Payment` down I wasn't exactly sure what would happen, so I took the time to figure it out. Apparently, the [`money-rails` gem] we use defaults to rounding down, which is the safer thing to do. [`money-rails` gem]: https://github.com/RubyMoney/money-rails
zspencer
changed the title
Tobias: Confirm issuing indivisible Payout#amount rounds each `…Tobias: Issuing indivisible Payout#amount rounds each Payment#amount down
zspencer
deleted the
tobias/issuing-payouts-round-payment-amount-down-when-indivisible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't exactly sure what would happen, so I took the time to figure it out.
Apparently, the
money-railsgem we use defaults to rounding down, which is the safer thing to do.