Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥔✨ Journal: Browsing Entries #4

Open
2 tasks done
Tracked by #1
zspencer opened this issue Jul 13, 2023 · 0 comments
Open
2 tasks done
Tracked by #1

🥔✨ Journal: Browsing Entries #4

zspencer opened this issue Jul 13, 2023 · 0 comments
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great

Comments

@zspencer
Copy link
Member

zspencer commented Jul 13, 2023 •
edited
Loading

Use Cases
@zspencer zspencer mentioned this issue Jan 29, 2024
Open
12 tasks
@zspencer zspencer changed the title Journal: Browsing Entries 🌫️✨ Journal: Browsing Entries Jul 13, 2023
@zspencer zspencer mentioned this issue Jul 13, 2023
Merged
@zspencer zspencer changed the title 🌫️✨ Journal: Browsing Entries 🥔✨ Journal: Browsing Entries Jul 13, 2023
zspencer referenced this issue in zinc-collective/convene Jul 13, 2023
@zspencer
Journal: Entries may be queried by Keywords
6f9a625 
- https://github.com/zinc-collective/convene/issues/1662
- https://github.com/zinc-collective/convene/issues/1566

This gets us a little bit closer to being able to browse `Entry` by
`Keyword`s, since each `Entry` will know it's keywords
@zspencer zspencer mentioned this issue Jul 13, 2023
Merged
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great labels Jul 13, 2023
zspencer referenced this issue in zinc-collective/convene Jul 15, 2023
@zspencer
Journal: Entries may be queried by Keywords
98096ed 
- https://github.com/zinc-collective/convene/issues/1662
- https://github.com/zinc-collective/convene/issues/1566

This gets us a little bit closer to being able to browse `Entry` by
`Keyword`s, since each `Entry` will know it's keywords
zspencer referenced this issue in zinc-collective/convene Jul 15, 2023
@zspencer
🧹 Journal: Entries store their Keywords (#1663)
d413ff8 
* `Journal`: `Entries` may be queried by `Keywords`

- https://github.com/zinc-collective/convene/issues/1662
- https://github.com/zinc-collective/convene/issues/1566

This gets us a little bit closer to being able to browse `Entry` by
`Keyword`s, since each `Entry` will know it's keywords

* `Journal`: `Keyword.search` provides case-insensitive tag search
zspencer referenced this issue in zinc-collective/convene Jul 15, 2023
@zspencer
Journal: Entry stores each Keyword it uses only once.
e8d5f2d 
- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662
@zspencer zspencer mentioned this issue Jul 15, 2023
Merged
zspencer referenced this issue in zinc-collective/convene Jul 20, 2023
@zspencer
🥗🧹 Journal: Entry stores each Keyword it uses only once. (#1675)
a6c4d02 
`Journal`: `Entry` stores each `Keyword` it uses only once.

- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662
zspencer referenced this issue in zinc-collective/convene Jul 20, 2023
@zspencer
🥔✨ Journal: Sprout Keywords#show (#1649)
2bb76ab 
* 🥔✨ `Journal`: Sprout `Keywords#show`

- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662

* Show Entries that match a Keyword or it's Aliases

* Use the canonical-keyword when building urls

* `Journal`: Extract `Entry.matching_keywords([...])` scope

* Spiff up the Presentation a touch
zspencer referenced this issue in zinc-collective/convene Jul 20, 2023
@zspencer
Journal: Entries link to their Keywords
4714a83 
- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662
@zspencer zspencer mentioned this issue Jul 20, 2023
Merged
zspencer referenced this issue in zinc-collective/convene Jul 20, 2023
@zspencer
Journal: Entries link to their Keywords
af1d8ea 
- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662
zspencer referenced this issue in zinc-collective/convene Jul 20, 2023
@zspencer
Journal: Entries link to their Keywords
cf3fb70 
- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662
zspencer referenced this issue in zinc-collective/convene Jul 20, 2023
@zspencer
🥔✨ Journal: Entries link to their Keywords (#1684)
5071b58 
- https://github.com/zinc-collective/convene/issues/1566
- https://github.com/zinc-collective/convene/issues/1662
zspencer referenced this issue in zinc-collective/convene Jul 27, 2023
@zspencer
🧹 Journal: Rename the method that turns Keywords into Links
6be22f4 
- #1684 (comment)
- https://github.com/zinc-collective/convene/issues/1662

Better name thanks to @rosschapman
@zspencer zspencer mentioned this issue Jul 27, 2023
Merged
zspencer referenced this issue in zinc-collective/convene Jul 27, 2023
@zspencer
🧹 Journal: Rename the method that turns Keywords into Links (#1708)
bfdf916 
- #1684 (comment)
- https://github.com/zinc-collective/convene/issues/1662

Better name thanks to @rosschapman
@zspencer zspencer mentioned this issue Jul 28, 2023
Open
4 tasks
@zspencer zspencer transferred this issue from zinc-collective/convene Jan 29, 2024
zspencer added a commit to zinc-collective/convene that referenced this issue Jan 29, 2024
@zspencer
🥗 Journal: Writing Entries: Test adding Entry#summary
bd64503 
- zinc-collective#2
- zinc-collective#6
- zinc-collective#4

Clearly, when I started
zinc-collective#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
This was referenced Jan 29, 2024
Merged
Open
zspencer added a commit that referenced this issue Jan 29, 2024
@zspencer
🥗 Journal: Writing Entries: Test adding Entry#summary
8f24440 
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
@zspencer
🥗 Journal: Writing Entries: Test adding Entry#summary
56f0f2a 
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
@zspencer
🥗 Journal: Writing Entries: Test adding Entry#summary
fdb42e8 
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
zspencer added a commit that referenced this issue Jan 29, 2024
@zspencer
🥗 Journal: Writing Entries: Test adding Entry#summary
d703b48 
- #2
- #6
- #4

Clearly, when I started
#8 I used the
wrong name. It's not an `Entry#description`, it's an `Entry#summary`!

Perhaps that would have been more obvious had I started with the spec,
rather than the data model. Ah well, inside out and outside in are both
valid.
@zspencer zspencer mentioned this issue Jan 31, 2024
Merged
zspencer added a commit to zinc-collective/convene that referenced this issue Feb 3, 2024
@zspencer
✨ Journal: Author provides Entry#summary (#2161)
64cc4aa 
- When zinc-collective#2, add an zinc-collective#10 so we can eventually display it when zinc-collective#4


* 🧹🥗 `Journal`: Add `Entry#summary` field (#8)

- zinc-collective#10

What I'm driving towards here is similar to
#2055, where a
`Journal::Entry` has an affordance for being opinionated about how it's
represented when linked to in search engines or peer-to-peer sharing; as
well as short text for when there are a several on `Journal#show`.

* 🛠️ `Journal`: Test only the `Journal in CI

While working on
zinc-collective#11, I realized I
missed a piece of the refactor because I was leaning-on-ci as a way to
confirm that everything was working as expected.

Little did I know, CI was not working in this fork. Which makes sense,
because you don't want to automatically turn on all the Workflows when
you fork a project.

This adds a Github Workflow for testing *just* the `Journal`, which
should make detecting oopsie-daisys a bit easier for folks who are only
interested in working on the Journal.

* 🥗 `Journal`: Test adding `Entry#summary` when Writing `Entries`

- zinc-collective#10
- zinc-collective#2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.

* ✨ `Journal`: Save `Entry#summary` when Writing `Entries`

- zinc-collective#2
- zinc-collective#10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
@zspencer zspencer mentioned this issue Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zspencer