🐞🔨 Pagination: Fix missing translation error for Next and Previous links
#2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #2216 With the Pagy 7 upgrade; the helper I wrote so we could add spacing between the Pagination links broke. This switches out from doing an in-ruby style override to an in-css style override; which should be less fraught.
zspencer
force-pushed
the
journal/fix-pagination-links
branch
from
7e9afc3 to
96cde68
Compare
zspencer
changed the title
Pagination: Apply Pagy themes via CSSPagination: Fix missing translation error for Next and Previous links
rosschapman
approved these changes
Feb 20, 2024
zspencer
added a commit
to zinc-collective/tobias
that referenced
this pull request
Mar 25, 2024
…us` links (zinc-collective#2217) - zinc-collective#2216 With the Pagy 7 upgrade; the helper I wrote so we could add spacing between the Pagination links broke. This switches out from doing an in-ruby style override to an in-css style override; which should be less fraught.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal: BrowsingEntriesjournal#4Marketplace:ShopperOrderHistory#1661DesignLibrary:Pagination#2216With the Pagy 7 upgrade; the helper I wrote so we could add spacing between the Pagination links broke.
This switches out from doing an in-ruby style override to an in-css style override.
After
Before