Memberships: Adds Breadcrumb from Membership: Show page #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when working on the [Journal](https://github.com/zinc-collective/convene/issues/898) that when you click on the `Account` link, it kind of drops you into the middle of no where. This adds a breadcrumb, so we can find our way back! Yay!
|
Does breadcrumbs need any test coverage added? Or is it such a core feature of Rails that it's not going to break/is tested in other areas? |
|
I could imagine a world where it's useful to write unit tests for crumbs, especially for ones with conditional logic but I didn't want to spend time figuring out how to do it in a useful way beyond reloading the page. Note: Gretel is a gem not built directly into Rails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when working on the
Journal that when you click on the
Accountlink, it kind of drops you into the middle of no where.This adds a breadcrumb, so we can find our way back! Yay!
Before
After!