🌸Components: Remove blank space from Cards without content
#1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
changed the title
CardComponent layout
zspencer
changed the title
CardComponent layoutComponents: ImproveCard layout
zspencer
added
🧹 refactor
rosschapman
commented
Jul 27, 2023
Comment on lines
+9
to
+11
| <div class="flex flex-col space-y-3"> | ||
| <%= render onboarding_component %> | ||
| <%= render CardComponent.new do |card| %> |
There was a problem hiding this comment.
Author note: This flips layout handling of the CardComponent from the component itself to the container. Generally follows the (my) principle of Components should be unaware of their layout context.
zspencer
changed the title
Components: ImproveCard layoutComponents: Prevent empty space when rendering Card without content
zspencer
changed the title
Components: Prevent empty space when rendering Card without contentComponents: Remove blank space from Cards without content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DesignLibrary#1187Testing
CardComponentI could find and didn't notice any UI issues.Screenshots
Here's a before/after of the
Marketplace::ManagementComponenton the Manage Marketplace landing screen. If there is no content, the content section will not display: