🧹 Journal: Move Entry rendering to EntryComponent
#1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
added
✨ feature
zspencer
force-pushed
the
journal/introduce-terms
branch
from
632529a to
e3fd349
Compare
zspencer
force-pushed
the
journal/link-to-terms
branch
from
b934994 to
97c1c7a
Compare
zspencer
force-pushed
the
journal/introduce-terms
branch
from
1f7e22e to
06d3df7
Compare
zspencer
force-pushed
the
journal/link-to-terms
branch
from
97c1c7a to
415606a
Compare
zspencer
changed the title
Journal: Entry links to their TermsJournal: Entry links to their Keywords
zspencer
force-pushed
the
journal/link-to-terms
branch
from
37dbae4 to
3668ba5
Compare
zspencer
changed the base branch from
main
to
journal/entries-know-their-keywords
zspencer
force-pushed
the
journal/entries-know-their-keywords
branch
from
6f9a625 to
6ffd6bd
Compare
zspencer
force-pushed
the
journal/link-to-terms
branch
4 times, most recently
from
41de505 to
cc7950d
Compare
zspencer
changed the title
Journal: Entry links to their KeywordsJournal: Move Entry rendering to EntryComponent
- https://github.com/zinc-collective/convene/issues/1566 This refactor allows us to do post-processing of the markdown at the Component level, which has access to the rails URL builders; which should allow us to link to the `Keyword` within the `Entry#body`...
zspencer
force-pushed
the
journal/link-to-terms
branch
from
cc7950d to
cde1583
Compare
|
Here's where it links to the |
zspencer
added
🧹 refactor
rosschapman
reviewed
Jul 20, 2023
| super(*args, **kwargs) | ||
| end | ||
|
|
||
| def body_html |
There was a problem hiding this comment.
What about content_html not to confuse with the<body> tag. This might be more consistent with other components that define header/content/footer slots?
There was a problem hiding this comment.
Ah, I like that! I will do a follow up PR to rename Entry#body to Entry#content
rosschapman
reviewed
Jul 20, 2023
| let(:component) { described_class.new(entry: entry) } | ||
| let(:entry) { create(:journal_entry, body: "https://www.google.com @[email protected] #GoodTimes") } | ||
|
|
||
| it { is_expected.to have_link("https://www.google.com", href: "https://www.google.com") } |
There was a problem hiding this comment.
Any reason you're just testing the link existence and not other strings?
There was a problem hiding this comment.
Well, I could have done some tests to ensure headings have the appropriate ids and such; but this was the thrust of the work I was doing so it's what I focused on.
rosschapman
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal: WritingEntriesjournal#2This refactor allows us to do post-processing of the markdown at the Component level, which has access to the rails URL builders; which should allow us to link to the
Keywordwithin theEntry#body