Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥔✨ Journal: Strip whitespace from slug, headline, and name #1637

Merged
merged 1 commit into from
Jul 6, 2023
Merged

🥔✨ Journal: Strip whitespace from slug, headline, and name #1637

merged 1 commit into from
Jul 6, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Jul 6, 2023

Not really part of your PR, but now that we have the
strip_attributes gem, it might be worth throwing that on for
headline and body, just so that we don't store trailing/preceding
whitespace.

@zspencer
Journal: Strip whitespace from slug, headline, and name
9f0711b 
- https://github.com/zinc-collective/convene/issues/1566
- #1630 (comment)

> Not really part of your PR, but now that we have the
> `strip_attributes` gem, it might be worth throwing that on for
> `headline` and `body`, just so that we don't store trailing/preceding
> whitespace.
@zspencer zspencer requested review from a team July 6, 2023 00:33
anaulin
anaulin approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strip those attributes 💪🏼

@zspencer zspencer merged commit 8688478 into main Jul 6, 2023
@zspencer zspencer deleted the journal/stripe-whitespace-from-entries branch July 6, 2023 00:49
@zspencer zspencer changed the title Journal: Strip whitespace from slug, headline, and name 🥔✨ Journal: Strip whitespace from slug, headline, and name Jul 11, 2023
@zspencer zspencer added ✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaulin anaulin anaulin approved these changes

Assignees
No one assigned
Labels
✨ feature Reduces Client's Burden or Grants them Benefits 🥔 Satisfices It's good enough to use, but not particularly great
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zspencer @anaulin