Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background deletion blocked #51

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

haorenfsa
Copy link
Collaborator

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4be02a4) 80.06% compared to head (1f5c271) 80.08%.

Files Patch % Lines
pkg/controllers/milvus_controller.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   80.06%   80.08%   +0.02%     
==========================================
  Files          47       47              
  Lines        4880     4881       +1     
==========================================
+ Hits         3907     3909       +2     
+ Misses        820      818       -2     
- Partials      153      154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, mintcckey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haorenfsa haorenfsa added the lgtm looks good to merge label Nov 29, 2023
@sre-ci-robot sre-ci-robot merged commit c77fd02 into zilliztech:main Nov 29, 2023
14 checks passed
@haorenfsa haorenfsa deleted the background-deletion branch December 3, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants