Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check milvus pod stopped before finalize #28

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

haorenfsa
Copy link
Collaborator

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f4c56c8) 80.06% compared to head (8f62a47) 80.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   80.06%   80.07%   +0.01%     
==========================================
  Files          47       47              
  Lines        4770     4774       +4     
==========================================
+ Hits         3819     3823       +4     
  Misses        802      802              
  Partials      149      149              
Files Coverage Δ
pkg/controllers/component_condition.go 80.15% <100.00%> (ø)
pkg/controllers/milvus_controller.go 38.62% <100.00%> (+1.74%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa added the lgtm looks good to merge label Oct 19, 2023
@sre-ci-robot sre-ci-robot merged commit 88b5399 into zilliztech:main Oct 19, 2023
13 checks passed
@haorenfsa haorenfsa deleted the check-stop branch October 19, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants