Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rocksmq config #219

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix rocksmq config #219

merged 1 commit into from
Dec 6, 2024

Conversation

haorenfsa
Copy link
Collaborator

fix #218

Signed-off-by: haorenfsa <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (ab99941) to head (4f3576a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   80.69%   80.70%           
=======================================
  Files          56       56           
  Lines        6233     6234    +1     
=======================================
+ Hits         5030     5031    +1     
  Misses       1014     1014           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa added the lgtm looks good to merge label Dec 6, 2024
@sre-ci-robot sre-ci-robot merged commit fb5c64d into zilliztech:main Dec 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with setting rocksmq settings through config
2 participants