Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcd replicaCount #202

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

haorenfsa
Copy link
Collaborator

fix #197

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haorenfsa haorenfsa force-pushed the fix-etcd-replica branch 2 times, most recently from 5757ca6 to 4b6d2d6 Compare October 25, 2024 07:39
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (39df548) to head (3e9aef5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/util.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   80.92%   80.93%   +0.01%     
==========================================
  Files          57       57              
  Lines        6355     6364       +9     
==========================================
+ Hits         5143     5151       +8     
- Misses       1016     1017       +1     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: haorenfsa <[email protected]>
@haorenfsa haorenfsa added the lgtm looks good to merge label Oct 28, 2024
@sre-ci-robot sre-ci-robot merged commit 82a6643 into zilliztech:main Oct 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replicaCount=1 is not enforced
2 participants