Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy_ctrl: add HandleManualMode() #189

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

haorenfsa
Copy link
Collaborator

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (de93c17) to head (5fc4098).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/deploy_ctrl.go 28.57% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   81.91%   81.84%   -0.07%     
==========================================
  Files          56       56              
  Lines        5187     5223      +36     
==========================================
+ Hits         4249     4275      +26     
- Misses        746      756      +10     
  Partials      192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa added the lgtm looks good to merge label Sep 19, 2024
@sre-ci-robot sre-ci-robot merged commit d84ef0f into zilliztech:main Sep 19, 2024
15 checks passed
@haorenfsa haorenfsa deleted the advanced-rollout branch September 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants