fix : add config check for open and closed range settings #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@foxspy 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
include/knowhere/config.h
Outdated
| @@ -115,6 +115,7 @@ struct Entry<CFG_FLOAT> { | |||
| std::optional<CFG_FLOAT::value_type> default_val; | |||
| uint32_t type; | |||
| std::optional<std::pair<CFG_FLOAT::value_type, CFG_FLOAT::value_type>> range; | |||
| std::optional<std::pair<bool, bool>> range_included; | |||
There was a problem hiding this comment.
please consider packing range into a structure Range, which would contain all the logic, including something like bool Range::within(float value) {} and std::string Range::to_string() {} (which produces a string representation)
There was a problem hiding this comment.
Good idea~ I will apply it
foxspy
force-pushed
the
add_range_check_master
branch
2 times, most recently
from
d33e629 to
a088b60
Compare
|
/lgtm |
Signed-off-by: xianliang.li <[email protected]>
foxspy
force-pushed
the
add_range_check_master
branch
from
a088b60 to
5bf4dae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=========================================
+ Coverage 0 79.25% +79.25%
=========================================
Files 0 81 +81
Lines 0 6350 +6350
=========================================
+ Hits 0 5033 +5033
- Misses 0 1317 +1317 |
|
/lgtm |
|
/kind improvement |
foxspy
added a commit
to foxspy/knowhere
that referenced
this pull request
Nov 18, 2024
Signed-off-by: xianliang.li <[email protected]>
foxspy
added a commit
to foxspy/knowhere
that referenced
this pull request
Nov 18, 2024
Signed-off-by: xianliang.li <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* update raft to 24.10 (#914) Signed-off-by: yusheng.ma <[email protected]> Signed-off-by: xianliang.li <[email protected]> * fix Index parameters handling and anniterator (#913) Signed-off-by: Alexandr Guzhva <[email protected]> Signed-off-by: xianliang.li <[email protected]> * add range check (#915) Signed-off-by: xianliang.li <[email protected]> * fix knowhere ut (#918) Signed-off-by: xianliang.li <[email protected]> * raft index supports cosine similarity by normalizing the input data. (#924) Signed-off-by: yusheng.ma <[email protected]> Signed-off-by: xianliang.li <[email protected]> * compensate for the missing acceleration functions in ARM NEON. (#922) Signed-off-by: yusheng.ma <[email protected]> Signed-off-by: xianliang.li <[email protected]> * improve sparse vector index mmap: to mmap almost everything (#928) Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: xianliang.li <[email protected]> * move sparse index Add to build pool (#933) Add SparseInvertedIndexNodeCC to allow being thread safe growing index Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: xianliang.li <[email protected]> * sparse mmap on disk (#935) Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: xianliang.li <[email protected]> * use MAP_PRIVATE for mmapped file (#938) Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: xianliang.li <[email protected]> * sparse RangeSearch/AnnIterator to return raw distance (#944) * sparse: make the distance returned by RangeSearch and AnnIterator to be the raw instead of the quantized distance Signed-off-by: Buqian Zheng <[email protected]> * sparse: remove mutex in the index: we now use CC index if concurrent read/write is needed Signed-off-by: Buqian Zheng <[email protected]> --------- Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: xianliang.li <[email protected]> * Add optimized distance functions for PowerPC (#894) Added the PowerPC vector functions in src/simd/distances_powerpc.cc, src/simd/distances_powerpc.h. The hooks to the PowerPC functions are added in src/simd/hook.cc. Signed-off-by: Carl Love <[email protected]> Co-authored-by: Carl Love <[email protected]> Signed-off-by: xianliang.li <[email protected]> * enhance: optimize get norms function (#950) Signed-off-by: cqy123456 <[email protected]> Signed-off-by: xianliang.li <[email protected]> --------- Signed-off-by: yusheng.ma <[email protected]> Signed-off-by: xianliang.li <[email protected]> Signed-off-by: Alexandr Guzhva <[email protected]> Signed-off-by: Buqian Zheng <[email protected]> Signed-off-by: Carl Love <[email protected]> Signed-off-by: cqy123456 <[email protected]> Co-authored-by: presburger <[email protected]> Co-authored-by: Alexander Guzhva <[email protected]> Co-authored-by: Buqian Zheng <[email protected]> Co-authored-by: carll99 <[email protected]> Co-authored-by: Carl Love <[email protected]> Co-authored-by: cqy123456 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#37269