Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Tuya IAS function into contact & smoke #3608

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

prairiesnpr
Copy link
Contributor

@prairiesnpr prairiesnpr commented Dec 12, 2024

Proposed change

Originally, we had tuya_ias with the intention of having one method to handle any IAS requirements. Looking at #3605, I think having separate convenience methods does make sense. Unfortunately, adding tuya_contact for contact sensors while retaining tuya_ias for Fire/smoke sensors would be confusing. This PR add tuya_contact and tuya_smoke and then modifies tuya_ias to accept a converter.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (5f1a7f2) to head (6fa7e12).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3608   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         321      321           
  Lines       10366    10374    +8     
=======================================
+ Hits         9314     9322    +8     
  Misses       1052     1052           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Dec 12, 2024
@prairiesnpr prairiesnpr marked this pull request as ready for review December 13, 2024 00:25
@TheJulianJES TheJulianJES added the smash This PR is close to be merged soon label Dec 13, 2024
prairiesnpr and others added 2 commits December 12, 2024 20:51
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 979551d into zigpy:dev Dec 13, 2024
9 checks passed
@prairiesnpr prairiesnpr deleted the tuya-ias-clean branch December 13, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smash This PR is close to be merged soon Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants