-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Tuya IAS function into contact & smoke #3608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prairiesnpr
force-pushed
the
tuya-ias-clean
branch
from
December 12, 2024 23:32
2b00bf9
to
50651d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3608 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 321 321
Lines 10366 10374 +8
=======================================
+ Hits 9314 9322 +8
Misses 1052 1052 ☔ View full report in Codecov by Sentry. |
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
TheJulianJES
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Originally, we had tuya_ias with the intention of having one method to handle any IAS requirements. Looking at #3605, I think having separate convenience methods does make sense. Unfortunately, adding
tuya_contact
for contact sensors while retainingtuya_ias
for Fire/smoke sensors would be confusing. This PR addtuya_contact
andtuya_smoke
and then modifiestuya_ias
to accept a converter.Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black