Support multi-button presses on Philips remotes #3592
+121
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
ButtonPressQueue currently resets when receiving a button press from a different button than the previously received one. This prevents proper handling when pressing multiple buttons at the same time.
Additional information
Fixes #3591
This is still a draft. Would like to add another test to make sure multiple button presses are handled correctly. So far tests only check for multi-presses of the same button. Also want to wait for feedback from ericu65 in #3391
Checklist
pre-commit
checks pass / the code has been formatted using Black