Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-button presses on Philips remotes #3592

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

fholzer
Copy link
Contributor

@fholzer fholzer commented Dec 8, 2024

Proposed change

ButtonPressQueue currently resets when receiving a button press from a different button than the previously received one. This prevents proper handling when pressing multiple buttons at the same time.

Additional information

Fixes #3591

This is still a draft. Would like to add another test to make sure multiple button presses are handled correctly. So far tests only check for multi-presses of the same button. Also want to wait for feedback from ericu65 in #3391

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (97413e3) to head (0e279c4).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3592   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         323      323           
  Lines       10414    10416    +2     
=======================================
+ Hits         9351     9353    +2     
  Misses       1063     1063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fholzer fholzer force-pushed the fix-philips-multi-button-press branch from 8e1ce3b to 13011e6 Compare December 8, 2024 13:36
ButtonPressQueue currently resets when receiving a button press
from a different button than the previously received one. This
prevents proper handling when pressing multiple buttons at the
same time.
@fholzer fholzer force-pushed the fix-philips-multi-button-press branch from 13011e6 to 0e279c4 Compare December 8, 2024 13:45
@ericu65
Copy link

ericu65 commented Dec 9, 2024

Manual tested fix from PR and on RDM001 simultaneous presses of both switches while in mode 2 (dual rocker) both events are received correctly now.

@TheJulianJES TheJulianJES added the needs review This PR should be reviewed soon, as it generally looks good. label Dec 9, 2024
@fholzer fholzer changed the title Draft: Support multi-button presses on Philips remotes Support multi-button presses on Philips remotes Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR should be reviewed soon, as it generally looks good.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Philips Hue RDM001 simultaneous press not processed
3 participants