Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement contact attribute and skip on/off configuration for Philips SOC001 #3464

Closed
wants to merge 4 commits into from

Conversation

mguaylam
Copy link
Contributor

@mguaylam mguaylam commented Oct 26, 2024

Proposed change

Implement manufacturer specific contact attribute and skip on/off configuration for SOC001.
Since the on/off attribute does not support reporting configuration, network failure or shutdown will leave Home Assistant unaware of the new sensor state. Demonstrated here : #3432 (comment)

Additional information

Confirm binding works on the custom on/off. Tested between a light and this sensor.
Breaking change for previous installations by disabling the on/off entity creation.
Fixes #3314

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@mguaylam mguaylam marked this pull request as ready for review October 26, 2024 17:03
@mguaylam
Copy link
Contributor Author

mguaylam commented Nov 5, 2024

Should this go ahead because of zigpy/zha#289 ?

zhaquirks/philips/soc001.py Outdated Show resolved Hide resolved
@TheJulianJES
Copy link
Collaborator

We've discussed an alternative approach regarding this. Marking this PR as draft.

@TheJulianJES TheJulianJES marked this pull request as draft November 13, 2024 16:29
Co-authored-by: puddly <[email protected]>
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (c788758) to head (640f963).
Report is 35 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3464      +/-   ##
==========================================
+ Coverage   89.39%   89.45%   +0.05%     
==========================================
  Files         309      311       +2     
  Lines       10006    10040      +34     
==========================================
+ Hits         8945     8981      +36     
+ Misses       1061     1059       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] SOC001 - Philips Contact sensor
3 participants