Add "power outage memory" support for Aqara ceiling light L1-350 #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2658 +/- ##
==========================================
+ Coverage 86.78% 86.80% +0.01%
==========================================
Files 280 281 +1
Lines 8560 8571 +11
==========================================
+ Hits 7429 7440 +11
Misses 1131 1131
☔ View full report in Codecov by Sentry. |
corvis
force-pushed
the
feat/lumi_acn003
branch
2 times, most recently
from
dcd991d to
0d19096
Compare
corvis
force-pushed
the
feat/lumi_acn003
branch
from
0d19096 to
2da19bd
Compare
corvis
force-pushed
the
feat/lumi_acn003
branch
from
310f5c2 to
2c2813e
Compare
This quirk adds support for power on behavior of the device
TheJulianJES
force-pushed
the
feat/lumi_acn003
branch
from
2c2813e to
0b030e3
Compare
TheJulianJES
changed the title
TheJulianJES
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
LGTM. Thanks again for the PR!
(I've fixed the merge conflict that came up for the tests file and changed one comment slightly -- commits will be squashed when merging anyway.)
(As a note for myself: The power_outage_memory attribute for this lamp can also be exposed as a configuration switch in ZHA (Home Assistant Core). This can't be added only using quirks (yet).)
elupus
pushed a commit
to elupus/zha-device-handlers
that referenced
this pull request
Jan 17, 2024
…py#2658) feat: add support for aqara ceiling light L1-350 (zigpy#2649) This quirk adds support for power on behavior of the device
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
…py#2658) feat: add support for aqara ceiling light L1-350 (zigpy#2649) This quirk adds support for power on behavior of the device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This quirk adds support for power on behavior configuration of the device. Fixes #2649
Additional information
Test just verifies that signature definition is correct
Checklist
pre-commitchecks pass / the code has been formatted using Black