Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Owon PC321 support for custom attributes #2602

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 94 additions & 0 deletions zhaquirks/owon/Owon_PC321_Z.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
"""Quirk for Owon PC321 Z."""

from zigpy.profiles import zha
from zigpy.quirks import CustomCluster, CustomDevice
import zigpy.types as t
from zigpy.zcl.clusters.general import Basic, Identify
from zigpy.zcl.clusters.smartenergy import Metering

from zhaquirks.const import (
DEVICE_TYPE,
ENDPOINTS,
INPUT_CLUSTERS,
MODELS_INFO,
OUTPUT_CLUSTERS,
PROFILE_ID,
)
from zhaquirks.owon import Owon


class Owon_PC321_Z_Simple_Metering(CustomCluster, Metering):
"""Owon PC321 CustomCluster"""

ep_attribute: str = "smartenergy_metering"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't needed, because the ep_attribute is already set in Metering (which we're inheriting here)?


attributes = Metering.attributes.copy()
attributes.update(
{
0x2000: ("L1_phase_power", t.uint24_t, True),
0x2001: ("L2_phase_power", t.uint24_t, True),
0x2002: ("L3_phase_power", t.uint24_t, True),
0x2100: ("L1_phase_reactive_power", t.uint24_t, True),
0x2101: ("L2_phase_reactive_power", t.uint24_t, True),
0x2102: ("L3_phase_reactive_power", t.uint24_t, True),
0x2103: ("reactive_power_summation_of_the_3_phases", t.uint24_t, True),
0x3000: ("L1_phase_voltage", t.uint24_t, True),
0x3001: ("L2_phase_voltage", t.uint24_t, True),
0x3002: ("L3_phase_voltage", t.uint24_t, True),
0x3100: ("L1_phase_current", t.uint24_t, True),
0x3101: ("L2_phase_current", t.uint24_t, True),
0x3102: ("L3_phase_current", t.uint24_t, True),
0x3103: ("current_summation_of_the_3_phases", t.uint24_t, True),
0x3104: ("leakage_current", t.uint24_t, True),
0x4000: ("L1_phase_energy_consumption", t.uint48_t, True),
0x4001: ("L2_phase_energy_consumption", t.uint48_t, True),
0x4002: ("L3_phase_energy_consumption", t.uint48_t, True),
0x4100: ("L1_phase_reactive_energy_consumption", t.uint48_t, True),
0x4101: ("L2_phase_reactive_energy_consumption", t.uint48_t, True),
0x4102: ("L3_phase_reactive_energy_consumption", t.uint48_t, True),
0x4103: ("reactive_energy_summation_of_the_3_phases", t.uint48_t, True),
0x5005: ("frequency", t.uint8_t, True),
}
)


class Owon_PC321_Z(CustomDevice):
"""New Device Owon PC321 Z."""

signature = {
MODELS_INFO: [(Owon, "PC321")],
ENDPOINTS: {
# <SimpleDescriptor endpoint=1 profile=260 device_type=13
# device_version=1
# input_clusters=[0, 3, 1794]
# output_clusters=[3]>
1: {
PROFILE_ID: zha.PROFILE_ID,
DEVICE_TYPE: zha.DeviceType.CONSUMPTION_AWARENESS_DEVICE,
INPUT_CLUSTERS: [
Basic.cluster_id,
Identify.cluster_id,
Metering.cluster_id,
],
OUTPUT_CLUSTERS: [Identify.cluster_id],
},
},
}
replacement = {
ENDPOINTS: {
# <SimpleDescriptor endpoint=1 profile=260 device_type=13
# device_version=1
# input_clusters=[0, 3, 1794]
# output_clusters=[3]>
1: {
PROFILE_ID: zha.PROFILE_ID,
DEVICE_TYPE: zha.DeviceType.CONSUMPTION_AWARENESS_DEVICE,
INPUT_CLUSTERS: [
Basic.cluster_id,
Identify.cluster_id,
Owon_PC321_Z_Simple_Metering,
],
OUTPUT_CLUSTERS: [Identify.cluster_id],
},
},
}
3 changes: 3 additions & 0 deletions zhaquirks/owon/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""Owon quirks."""

Owon = "OWON Technology Inc."
Loading