Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya blind motor (Amazon US - HILADUO) _TZE200_9p5xmj5r variant #2593

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

mossyhub
Copy link
Contributor

This roller blind is sold on Amazon USA under the brand name HILADUO.

I have already added this as a custom quirk and tested it with my own blinds.

Proposed change

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This roller blind is sold on Amazon USA under the brand name HILADUO.

I have already added this as a custom quirk and tested it with my own blinds.
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Sep 17, 2023
moved it to the correct inverted class and added the required comma
@mossyhub mossyhub changed the title Add another Tuya blind motor Add another Tuya blind motor (Amazon US - HILADUO) Sep 19, 2023
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Will merge later, so we might be able to fix Python 3.12 CI first. (A new zigpy release needs to be made.)

@TheJulianJES TheJulianJES changed the title Add another Tuya blind motor (Amazon US - HILADUO) Add Tuya blind motor (Amazon US - HILADUO) _TZE200_9p5xmj5r variant Sep 22, 2023
@TheJulianJES TheJulianJES added the ready PR should be ready to merge label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7745c83) 86.54% compared to head (fe999b9) 86.54%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2593   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files         276      276           
  Lines        8502     8502           
=======================================
  Hits         7358     7358           
  Misses       1144     1144           
Files Changed Coverage Δ
zhaquirks/tuya/ts0601_cover.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 066812b into zigpy:dev Sep 23, 2023
14 checks passed
elupus pushed a commit to elupus/zha-device-handlers that referenced this pull request Jan 17, 2024
…zigpy#2593)

* Add another Tuya blind motor

This roller blind is sold on Amazon USA under the brand name HILADUO.
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
…zigpy#2593)

* Add another Tuya blind motor

This roller blind is sold on Amazon USA under the brand name HILADUO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR should be ready to merge Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants