Add Tuya TS011F plug variant, add Tuya 0x1888 cluster class
#2592
Conversation
TheJulianJES
changed the title
0x1888 cluster class
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2592 +/- ##
==========================================
+ Coverage 86.54% 86.55% +0.01%
==========================================
Files 276 276
Lines 8502 8511 +9
==========================================
+ Hits 7358 7367 +9
Misses 1144 1144
☔ View full report in Codecov by Sentry. |
zhaquirks/tuya/__init__.py
Outdated
|
|
||
| name = "Tuya Manufacturer Specific 1" | ||
| cluster_id = TUYA_CLUSTER_1888_ID | ||
| ep_attribute = "tuya_manufacturer_specific_1" |
There was a problem hiding this comment.
Not happy with that name, but don't have any nice suggestion. Maybe ep_attribute = "tuya_manufacturer_specific_1888"? or "tuya_manufacturer_specific_6280"?
There was a problem hiding this comment.
Changed it to append the decimal representation of the cluster ID now: a061fa6
.. or would hex be better? (I wonder if we already do something similar anything else?)
There was a problem hiding this comment.
I don't recall any similar 'labeling'.
Any approach would be fine to me, maybe the hex would direct match to the device signature, isn't it?
There was a problem hiding this comment.
I'll leave it in decimal for now. For hex, it might be confusing if we don't have 0x in front(?)
Doesn't really matter and we can always change it later, should we ever need to use the ep_attribute of those two clusters.
| cluster_id = TUYA_CLUSTER_E000_ID | ||
| ep_attribute = "tuya_is_pita_0" |
There was a problem hiding this comment.
This naming is made of @Adminiuga but i can being good getting somthing better as the old PITA ;-)
|
Hello, I see that _TZ3000_0zfrhq4i variant was added with this commit. The plug works, but showing big amounts of energy in Summation Delivered. Will it be fixed by this commit and I just need to wait for HA update? |
…2592) * Add Tuya TS011F plug variant * Use correct cluster: `TuyaZBE000Cluster` * Add `TuyaZB1888Cluster` cluster class due to it being outside manufacturer range * Use `TuyaZB1888Cluster` for new Tuya plug quirk * Change `ep_attribute` of Tuya clusters
…2592) * Add Tuya TS011F plug variant * Use correct cluster: `TuyaZBE000Cluster` * Add `TuyaZB1888Cluster` cluster class due to it being outside manufacturer range * Use `TuyaZB1888Cluster` for new Tuya plug quirk * Change `ep_attribute` of Tuya clusters
|
I still have the same problem. The 20A version of the plug (TZ3000_0zfrhq4i) reports the correct summation values while the 16A version (TZ3000_cehuw1lw) reports values that are like 50x higher. HA 2024.8.1 |
|
I also have problems with TZ3000_cehuw1lw. The summation is far from realistic. |
Proposed change
Adds yet another variant of the Tuya
TS011Fplug.Not sure if
TuyaZBMeteringClusterWithUnitis required or ifTuyaZBMeteringClusteris enough. (Couldn't we even merge those two classes?)It also adds a class for the Tuya
0x1888cluster (which is outside the manufacturer specific range, thus tests fail unless it has a custom cluster class).Additional information
Fixes #2573
✅
Waiting for confirmation in that issue that the custom quirk worksChecklist
pre-commitchecks pass / the code has been formatted using Black