Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heiman SmokeSensor-EF-3.0 support #2563

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

syssi
Copy link
Contributor

@syssi syssi commented Sep 3, 2023

Proposed change

This PR adds support for the Heiman SmokeSensor-EF-3.0. The quirk is pretty similar to #2157 but it looks like this device has an additional input cluster (PollControl).

Additional information

None.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (675fde8) 86.53% compared to head (a0f298c) 86.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2563   +/-   ##
=======================================
  Coverage   86.53%   86.54%           
=======================================
  Files         276      276           
  Lines        8499     8502    +3     
=======================================
+ Hits         7355     7358    +3     
  Misses       1144     1144           
Files Changed Coverage Δ
zhaquirks/heiman/smoke.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

Just to confirm, the IasWd cluster also isn't "working" for this device?

@syssi
Copy link
Contributor Author

syssi commented Sep 3, 2023

No it's isn't. It looks like the zigbee device goes unavailable if I try to talk to the IasWd cluster. If I don't touch this cluster the device stays available (for weeks now).

@TheJulianJES
Copy link
Collaborator

Huh, the "goes unavailable part" is interesting.

@TheJulianJES TheJulianJES merged commit f99806a into zigpy:dev Sep 3, 2023
14 checks passed
elupus pushed a commit to elupus/zha-device-handlers that referenced this pull request Jan 17, 2024
* Add Heiman SmokeSensor-EF-3.0 support by removing `IasWd` cluster from `replacement`
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
* Add Heiman SmokeSensor-EF-3.0 support by removing `IasWd` cluster from `replacement`
klolik pushed a commit to klolik/zha-device-handlers that referenced this pull request Aug 30, 2024
* Add Heiman SmokeSensor-EF-3.0 support by removing `IasWd` cluster from `replacement`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants