Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xiaomi Aqara B1 Curtain Motor (ZNCLDJ11LM) support #2523

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

hastarin
Copy link

@hastarin hastarin commented Aug 12, 2023

Proposed change

Adds a custom quirk for the Xiaomi Aqara B1 Curtain Motor (ZNCLDJ11LM) to fix issues described in #2451

Additional information

Fixes #2451

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Attention: Patch coverage is 43.07692% with 37 lines in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (a5d3ef7) to head (5ed1224).
Report is 197 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/xiaomi/aqara/curtain_b1.py 43.07% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2523      +/-   ##
==========================================
- Coverage   85.40%   85.08%   -0.32%     
==========================================
  Files         273      274       +1     
  Lines        8557     8622      +65     
==========================================
+ Hits         7308     7336      +28     
- Misses       1249     1286      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Collaborator

FYI, there were some changes to the other Aqara curtain quirks recently to clean them up a bit:

Ideally, this quirk could use/share some of the code for the E1 roller quirk.

@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Nov 8, 2023
@TheJulianJES TheJulianJES added the Xiaomi Request/PR regarding a Xiaomi device label Dec 24, 2023
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added stale Issue is inactivate and might get closed soon and removed stale Issue is inactivate and might get closed soon labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device Xiaomi Request/PR regarding a Xiaomi device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Aqara Curtain Motor B1 (ZNCLDJ11LM)
2 participants