-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for _TZE204_sxm7l9xa #2485
base: dev
Are you sure you want to change the base?
Conversation
d47ce54
to
3c56b06
Compare
Ok, I'll have to figure out later where we're duplicating (Thought this might be an easy port, but I'm still too much of a quirk newb.) |
zhaquirks/tuya/ts0601_motion.py
Outdated
TuyaMmwRadarTargetDistance, | ||
TuyaMmwRadarSensitivity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AnalogInput
cluster ID (extended) is duplicated here.
This Tuya stuff is already somewhat of a workaround everywhere. Are both clusters working correctly here like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work, yes, though in any case I now removed AnalogInput from the cluster. Not sure if the duplication is gone: I don't think all the tests are running against this PR.
zhaquirks/tuya/ts0601_motion.py
Outdated
@@ -398,6 +565,7 @@ class MmwRadarMotionGPP(CustomDevice): | |||
("_TZE200_ar0slwnd", "TS0601"), | |||
("_TZE200_sfiy5tfs", "TS0601"), | |||
("_TZE200_mrf6vtua", "TS0601"), | |||
("_TZE204_sxm7l9xa", "TS0601"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
("_TZE204_qasjif9e", "TS0601"), can be added here as well.
I tested locally on my machine and the sensor _TZE204_qasjif9e works perfectly with this quirk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_TZE204_qasjif9e is not the same as the other devices, the main properties are, however the settings are different and can't be changed this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. @pgroene has been kind enough to provide a separate PR for that one. 👍🏼
Just to conform this patch fixes ZHA integration for _TZE204_qasjif9e (motion_sensor) |
Hi! I'm using this patch for my _TZE204_sxm7l9xa and Occupancy, Detection Delay, Min Range and Max Range are working, however Fading Time and Sensitivity are always set back to 53000 mili seconds and 9, changing these values doesn't work. Also Illuminance is not working. For the quirk mentioned here Illuminance does work but Occupancy doesn't. |
Thanks @rrooggiieerr I've tried this quirk (after removing, restarting, and re-adding device) and I still don't seem to get the ability to change behaviour via "max range". |
Thanks for the work on this! I can confirm the occupancy detection is working on my _TZE204_sxm7l9xa. For me all five sliders all seem to reset their values after the occupancy changes state. |
And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices
b2c5ead
to
0793273
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2485 +/- ##
==========================================
- Coverage 86.54% 86.26% -0.28%
==========================================
Files 276 277 +1
Lines 8502 8564 +62
==========================================
+ Hits 7358 7388 +30
- Misses 1144 1176 +32
☔ View full report in Codecov by Sentry. |
And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices
0793273
to
1ef4b11
Compare
And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices
1ef4b11
to
4c40dba
Compare
I just updated the PR to fix this, based on some more info I found laying around. It should now be possible to actually change settings on _TZE204_sxm7l9xa. |
I can confirm that after removing and re-adding my _TZE204_sxm7l9xa in ZHA while having only the ts0601_radar.py file from the commit 4c40dba in the custom quirks folder:
Thanks again! |
So #2525 somewhat copied some of this. Since my review comments aren't addressed there (yet?), can you take a look at them? (They mostly apply to this PR too, especially: https://github.com/zigpy/zha-device-handlers/pull/2525/files#r1340849012) |
Did you get target distance working as well? If so, how? |
Adding to my last question, one very basic question: |
Any chance this sensor can be supported natively without using quirks? |
Can you add support for _TZE204_mtoaryre please? I tried adding to signatures in .py, it picks up the sensor but all entities are missing |
And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Is there some change that still needs to be made to this PR before it's able to be merged? What's keeping this open? |
@arbrandes are you still interested in getting this merged? It has been a long time :) but it seems you might be the only one who knows how to get past the last checks preventing a merge... thanks for your time! |
Proposed change
This primarily adds support for the _TZE204_sxm7l9xa Tuya millimeter wave sensor, and in doing so moves TS0601 radar support out of
ts0601_motion.py
to its own file,ts0601_radar.py
.This should also add control support to previously supported devices.
Additional information
This is a mashup of proposed quirks found mostly on #2378.
Checklist
pre-commit
checks pass / the code has been formatted using Black