Fix return type error when running incremental on first time ETL. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichaelward
force-pushed
the
patch-return-type-error
branch
from
a612e82 to
21e279e
Compare
| @@ -306,6 +306,6 @@ public function getIncrementalLastValue(): string | |||
| ->whereNotNull($this->updateColumn) | |||
| ->orderByDesc($this->updateColumn) | |||
| ->limit(1) | |||
| ->value($this->updateColumn); | |||
| ->value($this->updateColumn) ?? ''; | |||
There was a problem hiding this comment.
Would it make more sense to return null|string ?
There was a problem hiding this comment.
Absolutely. I considered that, but hoped for this to cause the least amount of disruption. The if ($incremental) check correctly fails on an empty string, so everything else downstream runs correctly.
We could change the return type, but that would require additional refactors elsewhere and a version bump for anyone who might be using it (which is only us based on the repos I have access to, but I don't know what else is out there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where running
artisan etls:run <etl-name> --incrementalagainst an empty database table will silently fail due to a mismatched return type inDbLoader::getIncrementalLastValue.getIncrementalLastValueuse's Laravel'sBuilderobject to build a query against the configured connection, ultimately returning the result of thevaluecall. This works when the destination database table already has data, because it returns the value of the last row in the configured column. However, when the database table is empty, thevaluecall returnsnull, which is not whatgetIncrementalLastValueexpects to return. The type is not converted and the extraction fails.